fix: fix problem when app token used without installation ID provided #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
approved these changes
Aug 14, 2024
TrishGillett
force-pushed
the
fix-installation-id
branch
from
38e1bdf
to
86d8d4f
Compare
|
|
This one would be good to ship sooner since it's impacting users, and then I can rebase #289. |
|
sorry about the delay, thanks for the quick turn around ! :) i was able to run with the patched commit and everything did work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the problem described by @camerondavison here, and introduced in #284.
If not provided, installation ID should be set to None, since that is the way
generate_app_access_tokenexpects a missing installation ID to be represented.