-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dialog when active contributors per month limit is hit #3676
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 11930671912Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I’ve left only comments about code styling and a suggestion for when apiSupportsSubscriptions is false.
This reverts commit 8f52a7e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny change, feel free to merge once adjusted 👍🏻 Thanks!
@@ -895,6 +901,10 @@ ApplicationWindow { | |||
storageLimitDialog.open() | |||
} | |||
|
|||
function onMonthlyContributorLimitReached( uploadSize ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use this uploadSize
anywhere. What would be nice though is to include the actual limit - similarly to what we did on plugin (see MerginMaps/qgis-plugin@f1ea460#diff-d5f841eda10b7504474461cbece2f5a718c04995de1956f64f1674138655c675R28)
function onMonthlyContributorLimitReached( uploadSize ) { | |
function onMonthlyContributorLimitReached( contributorsQuota ) { |
... aand yes, we will need to fix tests in case they will still be failing once the CI is re-run |
This PR add a new dialog when user try to sync while they have already hit the active contributor per month limit
Note for reviewer the error live and is triggered in
synchronizationerror
andsynchronizationmanager
Resolve https://github.com/orgs/MerginMaps/projects/15/views/1?pane=issue&itemId=86203521