Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project download #127

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix project download #127

merged 2 commits into from
Nov 2, 2023

Conversation

varmar05
Copy link
Contributor

This PR mitigates risk of performance penalty for file download:

  • do not load project.files from db if not needed
  • in download endpoint use db query to fetch file location instead of filtering in app

@varmar05
Defer loading project files
e6cae6b 
project files are rarely used compared to general usage of ORM Project, their load is deferred to avoid db performance issues
@varmar05
Optimize file download: Move file location lookup to db instead of py…
5424e97 
…thon.
@varmar05 varmar05 changed the base branch from master to develop October 31, 2023 11:57
@varmar05 varmar05 changed the base branch from develop to master October 31, 2023 11:58
mostlyAtNight
mostlyAtNight approved these changes Oct 31, 2023
View reviewed changes
Copy link

@mostlyAtNight mostlyAtNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you

luxusko
luxusko approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@luxusko luxusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varmar05 varmar05 merged commit d737d2b into master Nov 2, 2023
5 of 6 checks passed
@MarcelGeo MarcelGeo deleted the fix_project_download branch January 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxusko luxusko luxusko approved these changes

@mostlyAtNight mostlyAtNight mostlyAtNight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varmar05 @mostlyAtNight @luxusko