Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mohtly contributors count to send_statistics #316

Merged
merged 2 commits into from
Nov 5, 2024
Merged

add mohtly contributors count to send_statistics #316

merged 2 commits into from
Nov 5, 2024

Conversation

MarcelGeo
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11669084657

Details

  • 22 of 23 (95.65%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 93.799%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/sync/interfaces.py 2 3 66.67%
Totals Coverage Status
Change from base Build 11595329168: 0.002%
Covered Lines: 6338
Relevant Lines: 6757
💛 - Coveralls

tomasMizera
tomasMizera approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with sqlalchemy syntax, but it looks good to me

@MarcelGeo MarcelGeo merged commit eec1deb into develop Nov 5, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the gh#2578-callhome-contributors branch November 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varmar05 varmar05 varmar05 left review comments

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelGeo @coveralls @tomasMizera @varmar05