chore: update for react hooks guidelines

[Daniel-Cross]

Updating the user guidelines for React hooks.

[sethkfman]

@Daniel-Cross Thanks for getting these added. These are great.

[MajorLift]

Perhaps this is out of scope for this PR, but so long as we're discussing memoization tactics specifically, should we add some general remarks about React Compiler? This seems especially relevant now with the new react compiler beta release that supports react v17-18.

It appears that in general manual memoization will be stripped and replaced by React Compiler, and therefore could be removed altogether eventually, although it doesn't seem like this should affect our current code.

However, an exception to this rule is memoization that is intended to ensure correctness instead of performance benefits. Maybe we should add a guideline to highlight any new additions that fall under this category with a comment, so that we know not to remove them in the future.

It is generally safe to leave manual memoization in your code – the compiler understands it but will compile in its own lower-level form of memoization even for manually memoized code. The compiler does however check its memoization against manual memoization to ensure that we memoized it exactly the same. The reason we need to do this is in case the manual memoization was used for correctness. For example, if a manually memoized value was passed as a dependency to a useEffect call somewhere else and it wasn't memoized in the same way, this might cause over/under firing of effects or even infinite loops.

For this reason, our current recommendation is to leave manual memoization in for existing code, but for new code written after the compiler is added you can omit them.

-- reactwg/react-compiler#16 (comment)