Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release/182.0.0" #4599

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Aug 12, 2024

Reverts https://github.com/MetaMask/core/pull/4597/files

We need to redo this release since I missed some CI config/naming and this did not go out 🤦🏾 , apologies!

Context: I made and merged a release branch without checking the PR name. That PR name became the squashed commit, and therefore had an invalid name to kick off the release process...

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner August 12, 2024 13:14
Copy link

socket-security bot commented Aug 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network +4 926 kB metamaskbot

View full report↗︎

Copy link

socket-security bot commented Aug 12, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/[email protected] 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Usual revert PR.

@Prithpal-Sooriya
Copy link
Contributor Author

Yeah, again, sorry for this. Will retry.

@Prithpal-Sooriya Prithpal-Sooriya merged commit 128282f into main Aug 12, 2024
115 of 116 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the revert-failing-version-182.0.0 branch August 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants