chore: Rename ControllerMessenger to Messenger
#5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
rename-controller-messenger
branch
7 times, most recently
from
f7e4e7c to
d2c1c84
Compare
|
@metamaskbot publish-previews |
|
I'd like to test this in the clients before merging even though it's not breaking, as we've seen type incompatibilities before from private property renaming. |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
cryptodev-2s
approved these changes
Dec 11, 2024
Rename the `ControllerMessenger` to `Messenger` so that it is clear it can be used for more than just controllers. This was decided by this ADR: https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md Previous names have been preserved as aliases to avoid making this a breaking change. Relates to #4538
Gudahtt
force-pushed
the
rename-controller-messenger
branch
from
1d772cc to
9c00587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Rename the
ControllerMessengertoMessengerso that it is clear it can be used for more than just controllers.This was decided by this ADR: https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md
Previous names have been preserved as aliases to avoid making this a breaking change.
References
Relates to #4538
Changelog
See diff
Checklist