fix: check push notification compatibility before setting up firebase #5069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Before we were initialising firebase without checking if the browser has correct setup for it. Thus causing errors logs to be made. (not breaking the app, but still producing errors).
We now do a check to ensure we can initialise firebase.
References
MetaMask/metamask-extension#26173
Changelog
@metamask/notification-services-controller
getPushAvailability
method to check if we can use push notifications.getFirebaseMessaging()
now optionally returns null. This is an internal method not exposed outside.unsubscribePushNotifications
is not optional. This is internal and not exposed outside module.Checklist