Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide tokens without balance for multichain #12630

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix: hide tokens without balance for multichain #12630

merged 4 commits into from
Dec 11, 2024
+10 −8

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Dec 10, 2024 •
edited
Loading

Description

Fixed an issue where multi chain balance was not being calculated correctly for hide zero tokens settings. Also fixed an issue where the ticker was undefined in assets overview when it was a non-native token. These fixes belong to a feature that is hidden behind a feature flag PORTFOLIO_VIEW

Related issues

Fixes:

Manual testing steps

  1. Goto settings and turn on "Hide Tokens Without Balance"
  2. Observe that your zero tokens and tokens with no conversion rate disappear

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners December 10, 2024 23:09
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added team-assets portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 944460c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd03a164-f585-4348-8c3e-e9f8a4dff6ad

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Matt561
Matt561 previously approved these changes Dec 10, 2024
View reviewed changes
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 39abcd2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a593da0-fac9-4dd4-96d4-69cfa57be7a8

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 00049aa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7bfa3a01-e251-49fc-a148-5c99506fc8fa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nickewansmith
nickewansmith approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@vinnyhoward vinnyhoward added this pull request to the merge queue Dec 11, 2024
@vinnyhoward vinnyhoward removed this pull request from the merge queue due to a manual request Dec 11, 2024
@vinnyhoward vinnyhoward added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 226107b Dec 11, 2024
54 checks passed
@vinnyhoward vinnyhoward deleted the fix-multi-chain-non-zero-tokens branch December 11, 2024 02:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankvonhoven frankvonhoven frankvonhoven approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@nickewansmith nickewansmith nickewansmith approved these changes

@Matt561 Matt561 Matt561 left review comments

Assignees
No one assigned
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vinnyhoward @nickewansmith @sahar-fehri @brianacnguyen @Matt561 @frankvonhoven @metamaskbot