Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix asset options sheet #12859

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 8, 2025

Description

PR to fix options displayed in Asset Options bottom sheet.

Related issues

Fixes: #12660 (comment)

Manual testing steps

  1. Click on a native token on any network
  2. Click on asset options button on top right
  3. Notice that you should not see "Token Details" option

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-08.at.12.03.26.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 61551d4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e92d3863-a3f4-46b0-891d-041607787d43

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review January 8, 2025 11:05
@sahar-fehri sahar-fehri requested a review from a team as a code owner January 8, 2025 11:05
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
@sahar-fehri sahar-fehri enabled auto-merge January 8, 2025 16:11
@sahar-fehri sahar-fehri added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit e0864ad Jan 8, 2025
37 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-assetOptions-bottom-sheet branch January 8, 2025 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App error when navigating to token details page
4 participants