Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stablecoin lending feature flag #12911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add stablecoin lending feature flag #12911

wants to merge 2 commits into from
+20 −11

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Jan 8, 2025 •
edited
Loading

Description

This PR add a new feature flag for stable coin lending UI .

Related issues

Fixes: STAKE-893

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jan 8, 2025
@amitabh94 amitabh94 marked this pull request as ready for review January 8, 2025 23:08
@amitabh94 amitabh94 requested review from a team as code owners January 8, 2025 23:08
@amitabh94 amitabh94 enabled auto-merge January 8, 2025 23:09
@amitabh94 amitabh94 added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ce230af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d4980dbc-4116-43e2-ab3b-e4b3d4794f49

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nickewansmith
nickewansmith approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickewansmith nickewansmith nickewansmith approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitabh94 @nickewansmith @metamaskbot