Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from ~> 0.76.0 to ~> 1.7.0 in /common #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update rubocop requirement from ~> 0.76.0 to ~> 1.7.0 in /common #145

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.7

New features

  • #9260: Support auto-correction for Style/MultilineMethodSignature. (@koic)
  • #9282: Make Style/RedundantFreeze and Style/MutableConstant cops aware of frozen regexp and range literals when using Ruby 3.0. (@koic)
  • #9223: Add new Lint/AmbiguousAssignment cop. (@fatkodima)
  • #9243: Support auto-correction for Style/CommentedKeyword. (@koic)
  • #9283: Add new Style/HashExcept cop. (@koic)
  • #9231: Add new Layout/SpaceBeforeBrackets cop. (@koic)

Bug fixes

  • #9232: Fix Style/SymbolProc registering wrong offense when using a symbol numbered block argument greater than 1, i.e. [[1, 2]].map { _2.succ }. (@tdeo)
  • #9274: Fix error in Metrics/ClassLength when the class only contains comments. (@dvandersluis)
  • #9213: Fix a false positive for Style/RedanduntFreeze when using Array#*. (@koic)
  • #9279: Add support for endless methods to Style/MethodCallWithArgsParentheses. (@dvandersluis)
  • #9245: Fix Lint/AmbiguousRegexpLiteral when given a match_with_lvasgn node. (@dvandersluis)
  • #9276: Add support for endless methods to Style/SingleLineMethods. (@dvandersluis)
  • #9225: Fix Style/LambdaCall ignoring further offenses after opposite style is detected. (@sswander)
  • #9234: Fix the error for Style/KeywordParametersOrder and make it aware of block keyword parameters. (@koic)
  • #8938: Fix some ConfigurableEnforcedStyle cops to output Exclude file lists in --auto-gen-config runs. (@h-lame)
  • #9257: Fix false positive for Style/SymbolProc when the block uses a variable from outside the block. (@dvandersluis)
  • #9251: Fix extracted cop warning when the extension is loaded using --require. (@dvandersluis)
  • #9244: When a cop defined in an extension is explicitly enabled, ensure that it remains enabled. (@dvandersluis)
  • #8046: Fix an error for Layout/HeredocArgumentClosingParenthesis when there is an argument between a heredoc argument and the closing paretheses. (@koic)
  • #9261: Fix an incorrect auto-correct for Style/MultilineWhenThen when one line for multiple condidate values of when statement. ([@makicamel][])
  • #9258: Fix calculation of cop department for nested departments. ([@mvz][])
  • #9277: Fix Layout/EmptyLineBetweenDefs error with endless method definitions. (@dvandersluis)
  • #9278: Update Style/MethodDefParentheses to ignore endless method definitions since parentheses are always required. (@dvandersluis)

Changes

  • #9212: Make Style/RedundantArgument aware of String#chomp and String#chomp!. (@koic)
  • #8482: Allow simple math for Lint/BinaryOperatorWithIdenticalOperands cop. (@fatkodima)
  • #9237: Add IgnoredPatterns configuration to Lint/UnreachableLoop to allow for block methods that share a name with an Enumerable method. (@dvandersluis)
  • #9206: Allow extensions to disable cop obsoletions. (@dvandersluis)
  • #9262: Update Style/CollectionMethods to be handle additional arguments and methods that accept a symbol instead of a block. (@dvandersluis)
  • #9235: Allow --only and --except to be able to properly qualify cops added by require. (@dvandersluis)
  • #9205: Update Naming/MemoizedInstanceVariableName to handle dynamically defined methods. (@dvandersluis)
  • #9285: Add AllowPercentLiteralArrayArgument option for Lint/RedundantSplatExpansion to enable the option by default. (@koic)
  • #9208: Use Array#bsearch instead of Array#include? to detect hidden files. ([@dark-panda][])
  • #9228: Suppress any config warnings for rubocop -V. (@dvandersluis)
  • #9193: Add IgnoreLiteralBranches and IgnoreConstantBranches options to Lint/DuplicateBranch. (@dvandersluis)
Changelog

Sourced from rubocop's changelog.

1.7.0 (2020-12-25)

New features

  • #9260: Support auto-correction for Style/MultilineMethodSignature. ([@koic][])
  • #9282: Make Style/RedundantFreeze and Style/MutableConstant cops aware of frozen regexp and range literals when using Ruby 3.0. ([@koic][])
  • #9223: Add new Lint/AmbiguousAssignment cop. ([@fatkodima][])
  • #9243: Support auto-correction for Style/CommentedKeyword. ([@koic][])
  • #9283: Add new Style/HashExcept cop. ([@koic][])
  • #9231: Add new Layout/SpaceBeforeBrackets cop. ([@koic][])

Bug fixes

  • #9232: Fix Style/SymbolProc registering wrong offense when using a symbol numbered block argument greater than 1, i.e. [[1, 2]].map { _2.succ }. ([@tdeo][])
  • #9274: Fix error in Metrics/ClassLength when the class only contains comments. ([@dvandersluis][])
  • #9213: Fix a false positive for Style/RedanduntFreeze when using Array#*. ([@koic][])
  • #9279: Add support for endless methods to Style/MethodCallWithArgsParentheses. ([@dvandersluis][])
  • #9245: Fix Lint/AmbiguousRegexpLiteral when given a match_with_lvasgn node. ([@dvandersluis][])
  • #9276: Add support for endless methods to Style/SingleLineMethods. ([@dvandersluis][])
  • #9225: Fix Style/LambdaCall ignoring further offenses after opposite style is detected. ([@sswander][])
  • #9234: Fix the error for Style/KeywordParametersOrder and make it aware of block keyword parameters. ([@koic][])
  • #8938: Fix some ConfigurableEnforcedStyle cops to output Exclude file lists in --auto-gen-config runs. ([@h-lame][])
  • #9257: Fix false positive for Style/SymbolProc when the block uses a variable from outside the block. ([@dvandersluis][])
  • #9251: Fix extracted cop warning when the extension is loaded using --require. ([@dvandersluis][])
  • #9244: When a cop defined in an extension is explicitly enabled, ensure that it remains enabled. ([@dvandersluis][])
  • #8046: Fix an error for Layout/HeredocArgumentClosingParenthesis when there is an argument between a heredoc argument and the closing paretheses. ([@koic][])
  • #9261: Fix an incorrect auto-correct for Style/MultilineWhenThen when one line for multiple condidate values of when statement. ([@makicamel][])
  • #9258: Fix calculation of cop department for nested departments. ([@mvz][])
  • #9277: Fix Layout/EmptyLineBetweenDefs error with endless method definitions. ([@dvandersluis][])
  • #9278: Update Style/MethodDefParentheses to ignore endless method definitions since parentheses are always required. ([@dvandersluis][])

Changes

  • #9212: Make Style/RedundantArgument aware of String#chomp and String#chomp!. ([@koic][])
  • #8482: Allow simple math for Lint/BinaryOperatorWithIdenticalOperands cop. ([@fatkodima][])
  • #9237: Add IgnoredPatterns configuration to Lint/UnreachableLoop to allow for block methods that share a name with an Enumerable method. ([@dvandersluis][])
  • #9206: Allow extensions to disable cop obsoletions. ([@dvandersluis][])
  • #9262: Update Style/CollectionMethods to be handle additional arguments and methods that accept a symbol instead of a block. ([@dvandersluis][])
  • #9235: Allow --only and --except to be able to properly qualify cops added by require. ([@dvandersluis][])
  • #9205: Update Naming/MemoizedInstanceVariableName to handle dynamically defined methods. ([@dvandersluis][])
  • #9285: Add AllowPercentLiteralArrayArgument option for Lint/RedundantSplatExpansion to enable the option by default. ([@koic][])
  • #9208: Use Array#bsearch instead of Array#include? to detect hidden files. ([@dark-panda][])
  • #9228: Suppress any config warnings for rubocop -V. ([@dvandersluis][])
  • #9193: Add IgnoreLiteralBranches and IgnoreConstantBranches options to Lint/DuplicateBranch. ([@dvandersluis][])

1.6.1 (2020-12-10)

Bug fixes

  • #9196: Fix ConfigObsoletion::ExtractedCop raising errors for loaded features when bundler is not activated. ([@dvandersluis][])
Commits
  • 44270f4 Cut 1.7.0
  • eca0c87 Update Changelog
  • 7d1dece Add AllowPercentLiteralArrayArgument option to Lint/RedundantSplatExpansion
  • bee3bb5 Add new Style/HashExcept cop
  • d160595 Inline and remove inspect_source_file
  • f57312a Use new expect_offense and expect_correction
  • 8a85e4f Add InternalAffairs/StyleDetectedApiUse
  • 0ebbbe9 Add changelog entry
  • 21a97b6 [Fix #8938] Fix --auto-gen-config for Style/SpaceInsideBlockBraces
  • bd0131c [Fix #8938] Fix --auto-gen-config for Style/SpaceInsideHashLiteralBraces
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Copy link
Author

Dependabot tried to add @greysteil as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/Metaswitch/dependabot-core/pulls/145/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the Metaswitch/dependabot-core repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 28, 2020
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants