Use new headers crate instead of hyper-old-types #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Thebridge [email protected]
hyper-old-types
is no longer maintained. Switch to theheaders
hyper crate instead - https://docs.rs/headers/latest/headers/authorization/index.htmlThis is a breaking change because
swagger-rs
re-exported types.AuthData
enum variants just wrap Strings. This is slightly uglier, but the innerBasic
andBearer
types inheaders
can't be directly constructed, only decoded from an Authorization header, and this felt like a more efficient implementation.from_headers
method now returns anOption<AuthData>
, thus removing any public authentication type reexports and avoiding exposing the whole swagger ecosystem to upstream breaking changes.There were no existing tests of
AuthData
- not sure what would be useful to add, but will do if there's anything you think would help?