Skip to content

Commit

Permalink
PropertyPageNode: log full exception if any instead of popup only
Browse files Browse the repository at this point in the history
This issue did not show the root exception:
eclipse-jdt/eclipse.jdt.debug#570
  • Loading branch information
EcljpseB0T authored and jukzi committed Dec 2, 2024
1 parent 55329ed commit 6c459cc
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*******************************************************************************/
package org.eclipse.ui.internal.dialogs;

import java.util.List;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.jface.preference.IPreferencePage;
Expand Down Expand Up @@ -58,8 +59,9 @@ public void createPage() {
} catch (CoreException e) {
// Just inform the user about the error. The details are
// written to the log by now.
IStatus errStatus = StatusUtil.newStatus(e.getStatus(), WorkbenchMessages.PropertyPageNode_errorMessage);
StatusManager.getManager().handle(errStatus, StatusManager.SHOW);
IStatus errStatus = StatusUtil.newStatus(List.of(e.getStatus()),
WorkbenchMessages.PropertyPageNode_errorMessage, null);
StatusManager.getManager().handle(errStatus, StatusManager.SHOW | StatusManager.LOG);
page = new EmptyPropertyPage();
}
setPage(page);
Expand Down

0 comments on commit 6c459cc

Please sign in to comment.