Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Facebook): Add support for Facebook #127

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(Facebook): Add support for Facebook #127

wants to merge 5 commits into from

Conversation

bradgarropy
Copy link

@bradgarropy bradgarropy commented Jun 6, 2020

What: Add support for Facebook videos.

Why: Fixes #125.

How: Added src/tranformers/Facebook.js.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

This is still a work in progress. I created the PR as a draft to reflect that. Any early feedback is appreciated!

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          215       221    +6     
  Branches        27        27           
=========================================
+ Hits           215       221    +6     
Impacted Files Coverage Δ
src/transformers/index.js 100.00% <ø> (ø)
src/transformers/Facebook.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ecaf8...184db5d. Read the comment docs.

@bradgarropy
Copy link
Author

@MichaelDeBoey Okay, I think this one is ready to go!

@MichaelDeBoey MichaelDeBoey added the ⚙️ Facebook Issue or pull request regarding Facebook label Jun 7, 2020
@MichaelDeBoey MichaelDeBoey self-assigned this Jun 7, 2020
@michalkvasnicak
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Facebook Issue or pull request regarding Facebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Facebook
3 participants