Upgrade codebase to GraphQL v16

[MichalLytek]

WIP

[carlocorradini]

It's happening 😍🥳

[alvis]

It's coming!!! ❤️❤️❤️

[orefalo]

nice!

For anyone reading this - plz dont' forget to contribute $$$.
Maintaining an opensource project takes time and skills - nothing comes for free.

[EstebanBorai]

Thanks so much for the hard work @MichalLytek!

[angelo-moreira]

this is great, thank you, I have asked the company that I work for to contribute to this project.
❤️❤️❤️❤️❤️

[noxend]

@MichalLytek thank you! 🙌❤️

[hkd987]

I thought @MichalLytek had died or moved out to the woods leaving all traces of nodejs behind, but he has risen with an amazing Draft PR for us to all admire. May the gods of nodejs bless this draft PR with speed, no bugs, and a quick merge.

All kidding aside I really thought this project had died, and was just starting to plan our exit from type-graphql, but this PR gives me a warm fuzzy that we are headed in the right direction.

[jessekrubin]

I thought @MichalLytek had died or moved out to the woods leaving all traces of nodejs behind, but he has risen with an amazing Draft PR for us to all admire. May the gods of nodejs bless this draft PR with speed, no bugs, and a quick merge.

@hkd987 Much like Keith Richards (of the rolling stones), @MichalLytek cannot be killed by conventional weapons. He is nearly indestructible.

[bnussman]

This is exciting 🚀

[productdevbook]

reflect-metadata Can it use something else instead because it doesn't support esm. It's old.

[kt390256]

Hi Michal, this is amazing work and thank you for this! I was doing some researches and I found that the current version of tGQL only works with graphql 15.3.0, just want to know if v2.0 will be compatible with any other 15.x version(ideally 15.5) or 16.x version? Thanks in advance!

[vuki656]

Hi Michal, this is amazing work and thank you for this! I was doing some researches and I found that the current version of tGQL only works with graphql 15.3.0, just want to know if v2.0 will be compatible with any other 15.x version(ideally 15.5) or 16.x version? Thanks in advance!

Yes it will, 16.6. check the diff.

[MichalLytek]

reflect-metadata Can it use something else instead because it doesn't support esm. It's old.

@productdevbook Please list something else we can use for shimming reflect metadata api

[productdevbook]

reflect-metadata Can it use something else instead because it doesn't support esm. It's old.

@productdevbook Please list something else we can use for shimming reflect metadata api

https://github.com/abraham/reflection

[MichalLytek]

@productdevbook Have you tried using that? TypeGraphQL doesn't force to use reflect-metadata:

type-graphql/src/metadata/utils.ts

Lines 60 to 68 in 91ca9b1

	export function ensureReflectMetadataExists() {
	if (
	typeof Reflect !== "object" ||
	typeof Reflect.decorate !== "function" ||
	typeof Reflect.metadata !== "function"
	) {
	throw new ReflectMetadataMissingError();
	}
	}

type-graphql/src/errors/ReflectMetadataMissingError.ts

Lines 1 to 10 in 91ca9b1

	export class ReflectMetadataMissingError extends Error {
	constructor() {
	super(
	"Looks like you've forgot to provide experimental metadata API polyfill. " +
	"Please read the installation instruction for more details.",
	);
	Object.setPrototypeOf(this, new.target.prototype);
	}
	}

Maybe we can just list abraham/reflection and core-js/es7/reflect in docs as the alternatives?

[kt390256]

@vuki656 thanks much! sorry just one more question, do you know when will this be released? very excited about this

[vuki656]

@vuki656 thanks much! sorry just one more question, do you know when will this be released? very excited about this

I don't think there is a date.

[beeequeue]

Maybe we can just list abraham/reflection and core-js/es7/reflect in docs as the alternatives?

@abraham/reflection seems to work in my project 👍

[MaxAst]

Hey @MichalLytek, I'm happy to contribute to this PR in case you need support! Would just need some guidance w.r.t what's still left to do

[itpropro]

Hey @MichalLytek, I'm happy to contribute to this PR in case you need support! Would just need some guidance w.r.t what's still left to do

If we work on #1356, @MaxAst can also get a contribution towards his hacktoberfest stats 💪

[arimus]

Any word @MichalLytek at what is left and how we might be able to help?

I'm currently trying to create an Apollo server v4 Hapijs adapter, but looks like upgrading Apollo server pushes graphql to v16 and thus triggers this issue in the project I'm using to do the dev.

[MichalLytek]

If someone wants to help, please checkout the branch and run every example to see if all the presented features works ok. The one I've updated the codebase (like apollo federation or mikro-orm) should be checked but e.g. subscriptions might not work.

[MichalLytek]

It would not contain any change. The branch is just rebased from time to time:

[bombillazo]

Also, any documented changes to have an idea about the breaking changes?

[MichalLytek]

@bombillazo https://github.com/MichalLytek/type-graphql/blob/new-major-release/CHANGELOG.md#unreleased

[abjrcode]

I have tried to upgrade my project which uses this library extensively to use (2.0-beta) and I think I found a small bug in auth-middleware.ts.

It tries to check the prototype of authChecker to decide if it is a function or a class but functions which aren't arrow functions do have a prototype so it mistakenly thinks it needs to insatiate a class from the container

[MichalLytek]

@abjrcode Unfortunately, it's the only legit way to detect whether it's an arrow function or ES6 class. This check works for all other kind of checks, with middlewares too.
Happy to see a proposal of better mechanism, maybe new ES have something more sophisticated than printing the source code and regexing for class/function keyword.

[cjnoname]

Hi @MichalLytek ,

We have successfully upgraded to v2 beta and it works perfectly. Looking forward for the formal release.

Thanks

[bombillazo]

Been testing for a few days, no issues so far and we were able to migrate to Apollo 4 thanks to this!

[loan-laux]

Same here.

[fknop]

Can the beta version be considered stable? As in API changes?
Any ETA on the final release? :)

[carlocorradini]

Awesome! 😎🥳

[MichalLytek]

The PR has been renamed to GraphQL v16 support as that was the main scope of the changes.

The work on the v2.0 release will be done step-by-step on the master branch.
More info here: #1418