Merge pull request #34 from eclipse439/master

Update Edge Extension Tutorials to use Manifest V3
MicrosoftEdge · Jun 24, 2022 · 6f0298b · 6f0298b
2 parents 807c75a + 438b81e
commit 6f0298b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/extension-getting-started-part1/part1/manifest.json b/extension-getting-started-part1/part1/manifest.json
@@ -1,15 +1,15 @@
 {
   "name": "NASA Picture of the day viewer",
   "version": "0.0.0.1",
-  "manifest_version": 2,
+  "manifest_version": 3,
   "description": "A chromium extension to show NASA's Picture of the Day.",
   "icons": {
     "16": "icons/nasapod16x16.png",
     "32": "icons/nasapod32x32.png",
     "48": "icons/nasapod48x48.png",
     "128": "icons/nasapod128x128.png"
   },
-  "browser_action": {
+  "action": {
     "default_popup": "popup/popup.html"
   }
 }
diff --git a/extension-getting-started-part2/extension-getting-started-part2/manifest.json b/extension-getting-started-part2/extension-getting-started-part2/manifest.json
@@ -1,15 +1,15 @@
 {
   "name": "NASA Picture of the day viewer",
   "version": "0.0.0.1",
-  "manifest_version": 2,
+  "manifest_version": 3,
   "description": "A chromium extension to show NASA's Picture of the Day.",
   "icons": {
     "16": "icons/nasapod16x16.png",
     "32": "icons/nasapod32x32.png",
     "48": "icons/nasapod48x48.png",
     "128": "icons/nasapod128x128.png"
   },
-  "browser_action": {
+  "action": {
     "default_popup": "popup/popup.html"
   },
   "content_scripts": [
@@ -21,6 +21,9 @@
     }
   ],
   "web_accessible_resources": [
-    "images/*.jpeg"
+    {
+      "resources": ["images/*.jpeg"],
+      "matches": ["<all_urls>"]
+    }
   ]
 }
diff --git a/extension-getting-started-part2/extension-getting-started-part2/popup/popup.js b/extension-getting-started-part2/extension-getting-started-part2/popup/popup.js
@@ -5,7 +5,7 @@ if (sendMessageId) {
       chrome.tabs.sendMessage(
         tabs[0].id,
         {
-          url: chrome.extension.getURL("images/stars.jpeg"),
+          url: chrome.runtime.getURL("images/stars.jpeg"),
           imageDivId: `${guidGenerator()}`,
           tabId: tabs[0].id
         },