Allow default value for CoverArtCache path #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7776360839
💛 - Coveralls |
s-martin
reviewed
Feb 4, 2024
| def __init__(self, cache_folder_path): | ||
| self.cache_folder_path = cache_folder_path | ||
| def __init__(self): | ||
| coverart_cache_path = cfg.setndefault('webapp', 'coverart_cache_path', value='../../src/webapp/build/cover-cache') |
There was a problem hiding this comment.
I'm wondering is there a use case where a user needs that path configurable?
There was a problem hiding this comment.
The question applies on many vars in the yaml.
I assume we can think of the yaml as a global var handler.
There was a problem hiding this comment.
I'm wondering is there a use case where a user needs that path configurable?
It's not required to be configurable, especially now that it is handled in its own class. Yet, it's a best practice at the moment. We might want to review the jukebox.yaml and check, if this could be done differently!
Groovylein
approved these changes
Feb 4, 2024
s-martin
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.