Merge pull request #30 from rizdaprasetya/travis-check

Merge Travis check
Midtrans · Jul 20, 2020 · 0a0198c · 0a0198c
2 parents e56c040 + 0356795
commit 0a0198c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 composer.lock
 composer.phar
-vendor/
+vendor/
+.idea
diff --git a/Midtrans/Snap.php b/Midtrans/Snap.php
@@ -62,7 +62,7 @@ public static function createTransaction($params)
         )
         );
 
-        if (array_key_exists('item_details', $params)) {
+        if (isset($params['item_details'])) {
             $gross_amount = 0;
             foreach ($params['item_details'] as $item) {
                 $gross_amount += $item['quantity'] * $item['price'];

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "midtrans/midtrans-php",
     "description": "PHP Wrapper for Midtrans Payment API.",
     "homepage": "https://midtrans.com",
-    "version": "2.3.0",
+    "version": "2.3.1",
     "type": "library",
     "license":"GPL-3.0",
     "authors": [

diff --git a/tests/MidtransCoreApiTest.php b/tests/MidtransCoreApiTest.php
@@ -41,8 +41,9 @@ public function testCharge()
         $this->assertTrue(in_array('X-Override-Notification: https://example.com', $fields["HTTPHEADER"]));
     }
 
-    public function testRealConnect()
+    public function testRealConnectWithInvalidKey()
     {
+        Config::$serverKey = 'invalid-server-key';
         $params = array(
             'transaction_details' => array(
             'order_id' => rand(),