Skip to content

Commit

Permalink
Run spotbugs checks rather than spotbugs
Browse files Browse the repository at this point in the history
It seems I misunderstood how to use spotbugs. By using check, verify
will fail and that's what we want
  • Loading branch information
Migwel committed Dec 25, 2023
1 parent dc351a1 commit 8ed818d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/dev_push_maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ jobs:
cache: maven
- name: Build with Maven
run: mvn -B verify --file pom.xml
- uses: jwgmeligmeyling/spotbugs-github-action@master
with:
path: '**/spotbugsXml.xml'
3 changes: 1 addition & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,13 @@
<version>4.8.0.0</version>
<configuration>
<xmlOutput>true</xmlOutput>
<failOnError>false</failOnError>
</configuration>
<executions>
<execution>
<id>verify</id>
<phase>verify</phase>
<goals>
<goal>spotbugs</goal>
<goal>check</goal>
</goals>
</execution>
</executions>
Expand Down

0 comments on commit 8ed818d

Please sign in to comment.