Merge pull request #81 from anxdpanic/dev

2.0.1~alpha2

addon.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<addon id="script.skinshortcuts" name="Skin Shortcuts" version="2.0.1~alpha1" provider-name="BigNoid, marcelveldt, SiLVO">
+<addon id="script.skinshortcuts" name="Skin Shortcuts" version="2.0.1~alpha2" provider-name="BigNoid, marcelveldt, SiLVO">
     <requires>
         <import addon="xbmc.python" version="3.0.0"/>
         <import addon="script.module.unidecode" version="1.1.1+matrix.2"/>
@@ -9,6 +9,7 @@
     <extension point="xbmc.addon.metadata">
         <news>
 [fix] some widgets not working |contrib: bumpaneer|
+[fix] new widget properties not being properly saved and applied |contrib: bumpaneer|
 [fix] fix configuration of widgets/actions on some skins |contrib: eXoterr|
 [lang] update translations from Weblate
         </news>

resources/lib/skinshorcuts/xmlfunctions.py

@@ -889,11 +889,12 @@ def build_element(self, item, group_name, visibility_condition, profile_visibili
         fallback_properties, fallbacks = self.data_func.get_custom_property_fallbacks(group_name)
 
         # Add fallback properties
+        source_properties = dict(properties)
         for key in fallback_properties:
             if key not in all_props:
                 # Check whether we have a fallback for the value
                 for property_match in fallbacks[key]:
-                    if has_fallback_property(property_match, properties):
+                    if has_fallback_property(property_match, source_properties):
                         additionalproperty = ETree.SubElement(newelement, "property")
                         additionalproperty.set("name", key)
                         additionalproperty.text = property_match[0]