Add compatibility to default icinga2 graphite writer. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bring opening curly braces in if-clauses to the same line. * Break long lines with conditions along the logical operators (&&, ||). * Break long lines along contitional operators. * Fix identation of array * Break long lines with array-definition around commas.
* Make graphite configuration compatible to defaults of icinga2 graphite writer. But keep compatibility to existing installations. * Introduce a selector "Graphite graph type" with options: * "auto" - alter graphite path if serviceName is instance of host or services * "host" - force path 'host' * "services" - force path 'services' * Introduce new DefaultPanelIds for a host and services if backend is graphite * Add defaults, helper functions for the new graphType and PanelIds * Alter some function interfaces to include graphType. * Add '&type=%s' to format strings * Camel Case ImgController->getMyImageHtml() * Remove empty lines
* Add some debug information * Break long lines
* Add a panels that honor the graphType for automatic selection of branches. * Add hostalive4 panels that render the different metrics pl and rta.
|
First thanks for helping making the module better. Please make a PR without changing so much formating (phpStorm did a good job). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icinga2-graphite writer distinguishes between metrics
that are attached to a hosts and those that are attached to services.
This patch-set makes it easier to switch between graphite and grafana modules,
by making the graphite path ($hostname -> $type (host|services)) -> …) configurable
in icingaweb2-module-grafana. I did my best to not break existing installations,
all changes should be limited to the graphite datasource.
Defaults in icinga2-graphite writer should be sufficient to satisfy both modules.
Furthermore: clean up some code.
Please pull it in soon. Thanks.