Fix dependency sort when dependencies have multiple environments #477
+53
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Milad-Akarie Hello, do you believe there is a way I can improve on this possible solution? |
This was referenced Oct 24, 2024
|
@Milad-Akarie, can you take a look at this PR? |
|
Same issue here! When will be merged and released? |
|
Is there any update on this? @Milad-Akarie |
|
I have added a unit test that proves the fix @Milad-Akarie. |
|
Thanks, working perfectly! @Milad-Akarie could you please merge? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, right now there is an issue regarding the order the dependencies are registered when using multiple environments.
Let's say we have a class UserApi which we annotate with @dev, then we create another class FakeUserApi which implements UserApi, we register that class as UserApi and annotate it with @test. Now we have a class UserRepository in which we inject UserApi. Now UserRepository has no environments annotated to it so in locator.config.dart there might be a case where the registrations would be in this order FakeUserApi then UserRepository then UserApi.