You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is possible to configure an onUpload method for the ImageBlock component. This allows you to upload the selected image and return the URL. For our application we already have a collection of images available and it would be nice if the user could also select an image instead of always uploading a new one.
For this I added an selectUpload method which can be configured for the ImageBlock component. This expects a Promise as return value, which works similar to the onUpload configuration option but does not pass a file. Hopefully this is useful for others as well.
How did you test this change?
Since the implementation for this can vary a lot for each implementation, I added a Storybook story to demonstrate the behavior.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@Saul-Mirone The only difference between the existing onUpload option and the new selectUpload is that in the first case the end-user gets a system file picker to select a file from the file system and with the latter you would need to implement some kind of file picker yourself. This could be used for example in a CMS where there is an existing library of images to choose from. Hope this makes sense, if not I can extend the storybook example.
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add a new event handler here to handle both onclick and onpointerdown, a possible solution should be still use onUpload without introducting another config. We can pass event to the onUpload config to let users open their own file picker.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently it is possible to configure an
onUploadmethod for theImageBlockcomponent. This allows you to upload the selected image and return the URL. For our application we already have a collection of images available and it would be nice if the user could also select an image instead of always uploading a new one.For this I added an
selectUploadmethod which can be configured for theImageBlockcomponent. This expects a Promise as return value, which works similar to theonUploadconfiguration option but does not pass a file. Hopefully this is useful for others as well.How did you test this change?
Since the implementation for this can vary a lot for each implementation, I added a Storybook story to demonstrate the behavior.