Skip to content

Commit

Permalink
Merge branch 'rampup' into fix/fork-config-rename
Browse files Browse the repository at this point in the history
  • Loading branch information
emberian authored Feb 13, 2024
2 parents 791100d + d6cc26f commit 8daa795
Show file tree
Hide file tree
Showing 2,830 changed files with 1,626,723 additions and 925,199 deletions.
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Ignore vendored code when calculating repo code %s
# libsnark is lots of c++
src/lib/snarky/src/camlsnark_c/libsnark-caml/* linguist-vendored
automation/** linguist-vendored
# PragmataPro requires a license and costs $$, let's protect it with password
# protected zip file
frontend/website/static/font/PragmataPro.zip filter=lfs diff=lfs merge=lfs -text
Expand Down
122 changes: 122 additions & 0 deletions .github/ISSUE_TEMPLATE/1-BUG_REPORT.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
name: "🐛 Bug report"
description: Something isn't working as expected? Report your bugs here.
labels: ["bug", "triage"]
body:
- type: markdown
attributes:
value: |
# Welcome 👋
Thanks for taking the time to fill out this bug report.
Please fill out each section below. This info allows Mina maintainers to diagnose (and fix!) your issue as quickly as possible. Otherwise we might need to close the issue without e.g. clear reproduction steps.
Bug reports also should not be used for support requests about a specific problem in your deployments, please use GitHub Discussions for that.
Useful Links:
- Documentation: https://docs.minaprotocol.com/
- Developer README file: `README-dev.md`
- Contributing: check `CONTRIBUTING.md`
- type: checkboxes
attributes:
label: Preliminary Checks
description: Please make sure that you verify each checkbox and follow the instructions for them.
options:
- label: "This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues"
required: true
- label: "This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions"
required: true
- type: textarea
attributes:
label: Description
description: Describe the issue that you're seeing.
placeholder: Be as precise as you can. Feel free to share screenshots, videos, or logs.
validations:
required: true
- type: textarea
attributes:
label: Steps to Reproduce
description: Clear steps describing how to reproduce the issue.
value: |
1.
2.
3.
...
validations:
required: true
- type: textarea
attributes:
label: Expected Result
description: Describe what you expected to happen.
validations:
required: true
- type: textarea
attributes:
label: Actual Result
description: Describe what actually happened.
validations:
required: true
- type: dropdown
id: frequency
validations:
required: true
attributes:
label: How frequently do you see this issue?
multiple: false
options:
- Rarely
- Sometimes
- Frequently
- Always
- type: dropdown
id: impact
validations:
required: true
attributes:
label: What is the impact of this issue on your ability to run a node?
multiple: false
options:
- Low
- Medium
- High
- Blocker
- type: textarea
attributes:
label: Status
render: shell
description: Run "mina client status" in your project directory and paste the output here.
placeholder: |
You'll get an output similar to this:
Mina daemon status
-----------------------------------
Global number of accounts: 25865
Block height: 41391
...
Consensus time now: epoch=8, slot=1416
Consensus mechanism: proof_of_stake
Consensus configuration:
Delta: 0
k: 290
Slots per epoch: 7140
Slot duration: 3m
Epoch duration: 14d21h
Chain start timestamp: 2021-03-17 00:00:00.000000Z
Acceptable network delay: 3m
...
validations:
required: true
- type: markdown
attributes:
value: |
## Sharing logs 📋
We are currently developing a new service to safely enable our community upload their logs using this form, in the meanwhile please send your logs to our e-mail:
- Run "mina client export-logs";
- Upload the resulting tar.gz file to a hosting service (Google Drive, Dropbox, etc.);
- Share the link where we can download your logs with [email protected];
- type: textarea
attributes:
label: Additional information
description: Tell us anything else you think we should know.
43 changes: 43 additions & 0 deletions .github/ISSUE_TEMPLATE/2-DOCUMENTATION.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: 🪲 Error in documentation
description: Did you find an error in our documentation? Report your findings here.
labels: "type: documentation_error"
body:
- type: markdown
attributes:
value: |
# Welcome 👋
Thanks for taking the time to fill out this issue.
Please fill out each section below. This info allows Mina maintainers to triage and fix your issue as quickly as possible.
Useful links:
- Documentation: https://docs.minaprotocol.com/
- Contributing: check `CONTRIBUTING.md`
- type: checkboxes
attributes:
label: Preliminary Checks
description: Please make sure that you verify each checkbox and follow the instructions for them.
options:
- label: "This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues"
required: true
- label: "This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions"
required: true
- type: textarea
validations:
required: true
attributes:
label: Summary
description: |
What problem(s) did you run into that caused you to request a fix to the documentation or additional documentation? What questions do you think we should answer?
- type: textarea
validations:
required: true
attributes:
label: Steps to Resolve this Issue
description: How can the problem be solved? Are there any additional steps required? Do any other pages need to be updated?
value: |
1.
2.
3.
...
65 changes: 65 additions & 0 deletions .github/ISSUE_TEMPLATE/3-TEST_REPORT.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
name: 🪲 Failing test
description: Did you find a failing test in our CI? Report your findings here.
labels: "type: failing_test"
body:
- type: markdown
attributes:
value: |
# Welcome 👋
Thanks for taking the time to fill out this issue.
Please fill out each section below. This info allows Mina maintainers to triage and fix the failing test(s) as quickly as possible.
Useful links:
- Documentation: https://docs.minaprotocol.com/
- Contributing: check `CONTRIBUTING.md`
- type: checkboxes
attributes:
label: Preliminary Checks
description: Please make sure that you verify each checkbox and follow the instructions for them.
options:
- label: "This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues"
required: true
- label: "This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions"
required: true
- type: textarea
validations:
required: true
attributes:
label: Summary
description: |
List which test(s) are failing, and describe how you expect them to behave.
- type: textarea
validations:
required: true
attributes:
label: Steps to replicate this Issue
description: How can the problem be replicated? Are there any additional steps required?
value: |
1.
2.
3.
...
- type: textarea
attributes:
label: Console output
render: shell
description: Paste the output of the test(s) here.
validations:
required: true
- type: textarea
attributes:
label: Platform
description: Which platform do you use? Are there any special flags you are using?
placeholder: |
Platform: Ubuntu 21.04
FLAGS: --XPTO=1
validations:
required: true
- type: textarea
attributes:
label: Build link(s)
description: Provide the CI's URL where the build is failing
validations:
required: false
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
blank_issues_enabled: false
contact_links:
- name: 👀 Mina documentation
url: https://docs.minaprotocol.com/
about: Check out the Mina documentation for answers to common questions
- name: 🚀 Mina discussions
url: https://github.com/MinaProtocol/mina/discussions
about: Ask questions, request features & discuss RFCs
- name: Mina Discord
url: https://discord.com/invite/Vexf4ED
about: Ask questions, get help and discuss new things you're building with the Mina community
- name: Mina Telegram
url: https://t.me/minaprotocol
about: The official Mina Telegram
- name: Mina Twitter
url: https://twitter.com/MinaProtocol
about: The official Mina Twitter account
29 changes: 0 additions & 29 deletions .github/ISSUE_TEMPLATES/bug_report.md

This file was deleted.

19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATES/feature_request.md

This file was deleted.

7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATES/help.md

This file was deleted.

40 changes: 36 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,53 @@
### Welcome 👋

Thank you for contributing to Mina! Please see `CONTRIBUTING.md` if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.
If you cannot complete any of the steps below, please ask for help from a core
contributor.

### Incomplete Work

We feel it's important that everyone is comfortable landing incomplete projects
so we don't keep PRs open for too long (especially on develop). To do this we
don't want to forget that something is incomplete, don't want to be blocked on
landing things, and we don't want to land anything that breaks the daemon. We
don't want to forget to test the incomplete things whenever they are completed,
and finally we want to clean up after ourselves: any temporary cruft gets
completely removed before a project is considered done.

To achieve the above, we wish to keep track of incomplete work using a draft of
the release notes. We can share this part of the current draft at anytime with
external contributors. Moreover, we will review this draft during hardforks.

To ship incomplete work, put it behind feature flags -- prefer a runtime
CLI/daemon-config-style flag if possible, and only if necessary fallthrough to
compile time flags. Note that if you put code behind a compile time flag, you
_must_ ensure that CI is building all possible code paths. Don't land something
that doesn't build in CI.

## PLEASE DELETE EVERYTHING ABOVE THIS LINE
---

Explain your changes:
*

Explain how you tested your changes:
*

Explain how you tested your changes here.

Checklist:

- [ ] Dependency versions are unchanged
- Notify Velocity team if dependencies must change in CI
- [ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
- [ ] Document code purpose, how to use it
- Mention expected invariants, implicit constraints
- [ ] Tests were added for the new behavior
- Document test purpose, significance of failures
- Test names should reflect their purpose
- [ ] All tests pass (CI will check this if you didn't)
- [ ] Serialized types are in stable-versioned modules
- [ ] Does this close issues? List them:
- [ ] Does this close issues? List them

Closes #0000
* Closes #0000
Loading

0 comments on commit 8daa795

Please sign in to comment.