Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run only fast checks in rosetta int tests #14224

Merged
merged 49 commits into from
Oct 23, 2023

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Sep 27, 2023

Introduced parametrized script for rosetta integration test. Now, there are two parameters:

  • use_zkapps
  • mode (minimal,full)

Which can satisfy couple of goals:

  • Fast run in PR (no use_zkapps and mode=minimal)
  • Long run in Stable builds (use_zkapps and mode=full)
  • Run without using kapps (for tests with o1js and mina )
  • Run without using zkapps (for tests without o1js)

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-buid-me

@dkijania
Copy link
Member Author

!ci-build-me

1 similar comment
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

dkijania commented Oct 2, 2023

!ci-build-me

@dkijania
Copy link
Member Author

dkijania commented Oct 2, 2023

!ci-build-me

@dkijania dkijania marked this pull request as ready for review October 2, 2023 18:42
@dkijania dkijania requested a review from a team as a code owner October 2, 2023 18:42
@dkijania
Copy link
Member Author

dkijania commented Oct 3, 2023

!ci-build-me

@dkijania dkijania marked this pull request as draft October 4, 2023 07:06
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

Copy link
Contributor

@Sventimir Sventimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cd -
echo "Done."
done
send_value_transfer_txns &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating commands only makes sense if we run rosetta-cli check:data or check:construction.

Suggested change
send_value_transfer_txns &
if [[ "$MODE" == "full" ]]; then
send_value_transfer_txns &
fi

@dkijania
Copy link
Member Author

!ci-build-me

# Conflicts:
#	buildkite/scripts/rosetta-integration-tests.sh
#	dockerfiles/stages/3-builder
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 814aeb2 into berkeley Oct 23, 2023
1 check passed
@deepthiskumar deepthiskumar deleted the dkijania/tailor_rosetta_int_tests branch October 23, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants