Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/archive client decouple #14736

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Fix/archive client decouple #14736

merged 4 commits into from
Jan 10, 2024

Conversation

emberian
Copy link
Contributor

@emberian emberian commented Dec 18, 2023 •
edited by deepthiskumar
Loading

A different approach as mentioned in #14728
Closes #14755

@emberian emberian requested review from a team as code owners December 18, 2023 22:40
@emberian emberian changed the base branch from develop to rampup December 18, 2023 22:40
@emberian
Copy link
Contributor Author

!ci-build-me

@deepthiskumar deepthiskumar mentioned this pull request Jan 3, 2024
Closed
7 tasks
deepthiskumar
deepthiskumar previously requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for rampup8 release to land this

@deepthiskumar deepthiskumar dismissed their stale review January 9, 2024 21:50

Plan to include in rampup8

@deepthiskumar
Copy link
Member

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@emberian
Copy link
Contributor Author

!ci-build-me

@georgeee
Copy link
Member

!ci-build-me

@nholland94
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit c22a213 into rampup Jan 10, 2024
36 checks passed
@georgeee georgeee deleted the fix/archive-client-decouple branch January 10, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emberian @deepthiskumar @georgeee @nholland94