Error feedback on compile-prover discrepancies #14887
Draft
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of o1-labs/o1js#1363
Bumps snarky to o1-labs/snarky#834
This fixes what I would consider unexpected behaviour in the Poseidon gadget:
Previously, the Poseidon gadget mutated the array of states that form the witness for the Poseidon gate, after it had added that gate to snarky's
R1CS_constraint_system.twithassert_. This mutatedIn general, it seems desirable to not mutate constraints in the constraint system from outside, after they have been added. This could have been a major bug if
R1CS_constraint_system.add_constraintwouldn't have copied the Poseidon states itself (which it does though).In particular, this behaviour was blocking my work in o1-labs/o1js#1363, so I changed it by putting a copy of the mutable state into the constraint, instead of the state itself.