Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rosetta account creation fee reporting and improve testing #14945

Merged
merged 11 commits into from
Jan 25, 2024

Conversation

joaosreis
Copy link
Member

This PR fixes an issue where account creation fees were wrongfully reported in the situation where the account was created by an internal command instead of a user command.

This was both manually tested against a specific situation where the issue was initially found and by running rosetta-cli on the same network.

Additionally, this PR bundles some changes to improve the Construction API testing using rosetta-cli:

  • The process of broadcasting a transaction is now split in two. First, we do a dry-run with a "fake" fee, which performs exactly as a normal run except for the part where the payload is signed and submitted. Then, we generate the actual payload that is signed and submitted which is identical to the first one, except that the fee used is the suggested fee returned by the dry-run payload.
  • A new DSL file was added with a workflow to return all the funds distributed to the accounts created in the testing process to a predefined account. This is useful in a situation where we don't want the funds distributed to be completely lost after the test.
  • /network/status endpoint implementation now populates the .sync_status.synced field, which is useful for rosetta-cli testing as this is used to automatically identify whether or not the node is behind the tip.

Copy link
Contributor

@Sventimir Sventimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one optional suggestion below. 👍

@joaosreis joaosreis requested a review from a team as a code owner January 24, 2024 11:58
@joaosreis
Copy link
Member Author

!ci-nightly-me

This is included in a different PR.

This reverts commit 1f07034.
@joaosreis joaosreis removed the request for review from a team January 24, 2024 12:34
@joaosreis
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@deepthiskumar
Copy link
Member

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 28ad233 into rampup Jan 25, 2024
15 of 16 checks passed
@deepthiskumar deepthiskumar deleted the joaosreis/fix-rosetta-account-creation-fee branch January 25, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants