-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rosetta account creation fee reporting and improve testing #14945
Merged
deepthiskumar
merged 11 commits into
rampup
from
joaosreis/fix-rosetta-account-creation-fee
Jan 25, 2024
Merged
Fix Rosetta account creation fee reporting and improve testing #14945
deepthiskumar
merged 11 commits into
rampup
from
joaosreis/fix-rosetta-account-creation-fee
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sventimir
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one optional suggestion below. 👍
!ci-nightly-me |
This is included in a different PR. This reverts commit 1f07034.
!ci-build-me |
!ci-nightly-me |
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where account creation fees were wrongfully reported in the situation where the account was created by an internal command instead of a user command.
This was both manually tested against a specific situation where the issue was initially found and by running
rosetta-cli
on the same network.Additionally, this PR bundles some changes to improve the Construction API testing using
rosetta-cli
:/network/status
endpoint implementation now populates the.sync_status.synced
field, which is useful forrosetta-cli
testing as this is used to automatically identify whether or not the node is behind the tip.