Resize images in archive view #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaSourcerer
reviewed
Feb 1, 2017
.gitmodules
Outdated
| @@ -1,9 +1,6 @@ | |||
| [submodule "engine"] | |||
| path = engine | |||
| url = https://github.com/minds/engine-internal.git | |||
There was a problem hiding this comment.
I think this change is significantly reducing your chances of your PR getting approved.
commit 03e8dbf Author: Alex <[email protected]> Date: Wed Oct 19 22:04:00 2016 -0700 Run comparison on images for orientation Switch classes based on width and height commit e460515 Author: Alex <[email protected]> Date: Wed Oct 19 21:23:24 2016 -0700 Add minds-img-landscape and minds-img-portrait Add scss stylings for archive view commit 9bb99f5 Author: Alex <[email protected]> Date: Wed Oct 19 19:44:25 2016 -0700 Resize images in archive view Pure css scaling in browsers w/ polyfill support.
|
@DaSourcerer forgot about this pr, I squashed the important commits and removed the submodule changes. |
markharding
force-pushed
the
master
branch
4 times, most recently
from
b3d79c1 to
26b051e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure css scaling in browsers w/ polyfill support and javascript approach.