chore: Prepare for Release 0.14.0 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed internally, this contains the preparations for the 0.14.0 release. The release won't be done until we merge to |
sumitramanga
reviewed
May 1, 2024
sumitramanga
reviewed
May 1, 2024
There was a problem hiding this comment.
It would be good to fill in the keywords array with common search terms like 'Error reporting' whilst this exists! Seems like this will help with discovery within the npm registry :)
There was a problem hiding this comment.
Added them, feel free to modify the array as you think!
There was a problem hiding this comment.
Those key words look great! Thank you
|
Should we update the license within the main README to 2024? It's currently at 2016 |
|
Nit pick - In the README, there's a link like this - http://raygun.io/blog/2013/07/video-nodejs-error-handling-with-raygun/ It's a pretty old blog but might pay to just correct the URL |
|
Testing went well! Was able to receive errors. I was about to test Real User Monitoring but it looks like Node is not built for that product (I tried a simple test and couldn't get it to work) What I tested for this branch that was successful -
Besides the minor comments I've mentioned above, I'm ready to approve this PR! |
Co-authored-by: Sumitra Manga <[email protected]>
|
@sumitramanga I did the requested changes. |
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "raygun", | |||
| "description": "Raygun.io package for Node, written in TypeScript", | |||
| "version": "0.13.2", | |||
| "description": "Raygun package for Node.js, written in TypeScript", | |||
There was a problem hiding this comment.
Might be worthwhile to mention bun as well given the traction it seems to get?
package.json
Outdated
| "keywords": [] | ||
| "keywords": [ | ||
| "error", | ||
| "reporting" |
There was a problem hiding this comment.
Some more ideas (they don't have to be single words, I think)
crash reporting
error tracking
raygun
APM
There was a problem hiding this comment.
seems to be a mix of different formats: https://www.npmjs.com/search?q=crash
e.g. crash reporting crash-reporting crash reporting
There was a problem hiding this comment.
If you search for "crash reporting" you already get results with packages with them as separated words. I'd stick to that.
There was a problem hiding this comment.
debug
logging
might be relevant as well.
TheRealAgentK
approved these changes
May 2, 2024
|
I've approved already because I think the release as such is good, pending whatever comes out of the keyword discussion. But that's really just additional findability optimisation. |
|
I'll wait for the approval from @sumitramanga, and then I'll open the "rebase to master" in a new PR once this is merged into |
|
Had a chat with Miguel, let's just merge this in now and get Panos involved for the release PR next up |
miquelbeltran
added a commit
that referenced
this pull request
May 6, 2024
* refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * set version 0.14.0 * update changelog * Update package.json Co-authored-by: Sumitra Manga <[email protected]> * add Error reporting to keywords * update license copyright year * updated URL * added more keywords * moar keywords --------- Co-authored-by: Sumitra Manga <[email protected]>
miquelbeltran
added a commit
that referenced
this pull request
May 8, 2024
* ci: Create node.js.yml (#142) * ci: Create node.js.yml * Include "develop" in the branch list to run CI actions * trigger GitHub actions. * fix: Updating dependencies and fixes (#144) * chore: updated dependencies * chore: update to tslint-react 5.0.0 * fix: mixup between Request and RequestParams * fix: convert Express Request to RequestParams * fix: recreate package-lock to fix express dependency errors * fix: test tap command update * fix: test asserts * refactor: use equal instead of ok * Adding PR, bug report and feature request templates. * Update pull_request_template.md Committing @sumitramanga's suggestion Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Nice! Co-authored-by: Sumitra Manga <[email protected]> * Update .github/bug_report.md Co-authored-by: Sumitra Manga <[email protected]> * ci: #145 eslint setup (#156) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * chore: #148 upgrade examples (#157) * express example: upgrade dependencies and point to subfolder raygun package * using-domains: upgrade dependencies and reference local raygun * using-domains: upgrade dependencies and reference local raygun * add console logs and format using spaces * improved readme * improved readme + replace tabs by spaces * enforce changing API keys to run examples * ci: add PR title checks (#167) * ci: Update dependabot.yml (#168) * chore(deps): bump actions/checkout from 3 to 4 (#171) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/setup-node from 3 to 4 (#172) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Move pr.yml to workflows (#175) * refactor: #158 remove no-explicit-any ignore eslint rule (#159) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * update package lock in sample * Update lib/raygun.sync.worker.ts Co-authored-by: Sumitra Manga <[email protected]> * remove empty line --------- Co-authored-by: Sumitra Manga <[email protected]> * refactor: #158 remove no-this-alias ignore eslint rule (#160) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * update package lock in sample * refactor: #158 fix eslint rule "no-unused-vars" (#170) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * ci: #174 Prettier setup (#169) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * Update .github/workflows/node.js.yml Co-authored-by: Sumitra Manga <[email protected]> * fix workflow * add comments to the package.json * add missing files * remove fetch-depth: 0 --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: #158 document why no-var-requires ignore is necessary (#173) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * refactor: #158 configure no-undef eslint rule (#176) * removed tslint * add eslint * add default config * setup default config and npm run command * add command to node.js.yml * set rules to support current codebase * remove unused tslint.json * include sample files in eslint command * remove rule no-explicit-any * specify type for timer * remove any from filterKeys * explictly declare that error can be Error, String but still accept any from the end users * specify types in the sync worker * improve the IndexableError type * explain why any is allowed in CustomData * remove no-this-alias from eslint config * convert to arrow function to preserve this reference * use arrow functions to remove the need of a this alias * define httpoptions object instead of using this alias * add examples to prettier command * add prettier job to node js ci job * script fix * setup no-unused-vars lint rule * remove unused var * fixed lib/raygun.batch.ts * fix lib/raygun.offline.ts * cleanup lib/raygun.sync.transport.ts * fix lib/raygun.transport.ts * fix lib/raygun.ts * fix @typescript-eslint/no-unused-vars * fixs in test files * update package lock in sample * cleanup eslint config * config files * run npm run prettier * chore: document why no-var-requires ignore is necessary update comment * fix: #158 configure no-undef eslint rule * refactor: #158 configure no-unreachable eslint rule (#177) * refactor: #158 remove no-useless-catch eslint rule (#178) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * chore: Prepare for Release 0.14.0 (#179) * refactor: #158 configure no-unreachable eslint rule * refactor: #158 remove no-useless-catch eslint rule * set version 0.14.0 * update changelog * Update package.json Co-authored-by: Sumitra Manga <[email protected]> * add Error reporting to keywords * update license copyright year * updated URL * added more keywords * moar keywords --------- Co-authored-by: Sumitra Manga <[email protected]> * chore: Update package-lock.json (#180) * chore: update package-lock.json (#183) * chore: change author name (#185) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kai Koenig <[email protected]> Co-authored-by: Sumitra Manga <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Prepare for Release 0.14.0
Description 📝
Type of change
Updates
0.14.0Author to check 👓
Reviewer to check ✔️