Allow compilation on a Mac #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitplane
force-pushed
the
fix-makefile-mac
branch
from
266f08c
to
e139893
Compare
Apple's binutils ld removes externs from linked .a files unless you pass the -all_load flag, resulting in a build-time undefined symbol. Also, it uses -install_name rather than -soname I didn't change the name of the .so file. Might be a good idea to use cmake to support cross-platform compilation.
bitplane
force-pushed
the
fix-makefile-mac
branch
from
e139893
to
b67367d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's binutils ld ships with the default of
-undefined,errorso it will error on link, as thedownload_in_progresssymbol is stripped from the binary.Also, it uses -install_name rather than -soname
I didn't change the name of the .so file. Might be a good idea to use cmake to support cross-platform compilation instead, but this gets things working for me.