Add support for SR-IOV cni plugin #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
force-pushed
the
jell/new-sriov
branch
7 times, most recently
from
0a556f6 to
54ea3f2
Compare
jellonek
force-pushed
the
jell/new-sriov
branch
from
54ea3f2 to
3e8ba3e
Compare
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
jellonek
added a commit
that referenced
this pull request
Dec 12, 2017
Followup for #503 This commit covers third bullet point, providing recreated network interface in container namespace ready to reconfigure with original IPAM configuration needed for later CNI DEL invocation.
jellonek
added a commit
that referenced
this pull request
Dec 13, 2017
Followup for #503 This commit covers third bullet point, providing recreated network interface in container namespace ready to reconfigure with original IPAM configuration needed for later CNI DEL invocation.
jellonek
added a commit
that referenced
this pull request
Dec 13, 2017
Followup for #503 This commit covers third bullet point, providing recreated network interface in container namespace ready to reconfigure with original IPAM configuration needed for later CNI DEL invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before #508 on which this one depends.
Thinks which need additional work:
configfdalready in sources, but even after passing it through tapmanager/vmwrapper - there is an access error)RecreateContainerSideNetworkdepends on possibility to look on interfaces in container namespace, but when one is passed to VM it's disconnected from host. Better way of that would be to serialize full csn to metadatastore and deserialize in during this recreate, so there would be no need to try to guess pci address from the sysfscsn.Teardownrebinds interface kernel driver, but device is probably visible only on host and this func is called in container namespace. Also even on host it probably will have other mac address than our autogenerated (which is now used to find device), so instead of finding it using mac address it probably needs to be located onTapFDSource.Releaselevel by pci address, moved to container namespace and at the end renamed using name expected by cni plugin.This change is