Allow passing VideoOptions by value or by reference to new_with_options - Closes #38
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from issue #38.
This took a little more work than I was expecting, as I missed that
VideostoresVideoOptions, therefore we need a new lifetime parameter on Video to make this work. Unfortunately this is a breaking change for anyone storing aVideoin a struct (not sure why you would), but I was able to avoid the main one (users passing VideoOptions by value) by relaxing the type signature ofVideo::new_with_options().I also removed a redundant clone on the
Video::get_options()method, needed to be touched anyway for this change.