Add ability to supply own PO tokens #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick42d thank you for adding the PO token support. I am not sure why would we need Visitor Data, maybe it could increase some kind of "trust" score that the request comes from a real browser but that is just a guess, I believe just PO token is enough for now. |
nick42d
added a commit
to nick42d/rusty_ytdl
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially resolves #43.
Added new request_option to supply PO token. I have tested this with a PO token from my browser and confirmed that this resolves #44 when a correct token is supplied.
In a future PR I'd like to add the ability to supply own visitor data as well, but that will require a little more refactoring. @clytras it seems the PO token by itself is sufficient - if possible could you please explain why we might need visitor data as well?