-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Removed a dataset that is too big from the list used in PR acceptance test #1590
Fix: Removed a dataset that is too big from the list used in PR acceptance test #1590
Conversation
Even with the worst "offender" removed, acceptance tests will take longer overall after #1553. This will also affect the web validator. Will users be patient? And will there be timeouts? |
✅ Rule acceptance tests passed. |
Here is a list of feeds that take a long time as found in the logs for the acceptance tests of the GH action: 9756 secs no-unknown-agder-kollektivtrafikk-as-gtfs-1078 I will add them to the list of skipped feeds. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Closes #1587
Removed de-unknown-ulmer-eisenbahnfreunde-gtfs-1081 from the list of files used in the PR validation.
This file has over 40M shapes entries and it's just too big for the changes in #1553
Expected behavior:
The acceptance tests pass.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything