Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed a dataset that is too big from the list used in PR acceptance test #1590

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Sep 27, 2023

Summary:

Closes #1587

Removed de-unknown-ulmer-eisenbahnfreunde-gtfs-1081 from the list of files used in the PR validation.
This file has over 40M shapes entries and it's just too big for the changes in #1553

Expected behavior:

The acceptance tests pass.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue Sep 27, 2023 that may be closed by this pull request
@jcpitre
Copy link
Contributor Author

jcpitre commented Sep 27, 2023

Even with the worst "offender" removed, acceptance tests will take longer overall after #1553.
e.g. au-queensland-translink-brisbane-gtfs-1215 used to take 2:21 mins (see https://github.com/MobilityData/gtfs-validator/actions/runs/6249510665/job/16966559475) and is now 15:28 mins (see https://github.com/MobilityData/gtfs-validator/actions/runs/6328465567/job/17186892966)

This will also affect the web validator. Will users be patient? And will there be timeouts?

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1477 sources (~0 %) are corrupted.
Commit: f5832dc
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@jcpitre
Copy link
Contributor Author

jcpitre commented Sep 28, 2023

Here is a list of feeds that take a long time as found in the logs for the acceptance tests of the GH action:

9756 secs no-unknown-agder-kollektivtrafikk-as-gtfs-1078
2646 secs hu-unknown-volanbusz-gtfs-1836
1698 secs de-baden-wurttemberg-verkehrsverbund-rhein-neckar-gtfs-1173
1190 secs de-baden-wurttemberg-db-zugbus-regionalverkehr-alb-bodensee-gtfs-773
908 secs au-new-south-wales-train-replacement-bus-operators-gtfs-1322

I will add them to the list of skipped feeds.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1472 sources (~0 %) are corrupted.
Commit: 4faeeda
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcpitre jcpitre merged commit 6f450a3 into master Sep 28, 2023
280 checks passed
@jcpitre jcpitre deleted the 1587-acceptance-tests-keeps-running-for-hours branch September 28, 2023 13:43
@jcpitre jcpitre mentioned this pull request Oct 2, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests keeps running for hours
2 participants