feat: add memory metrics to acceptance tests #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
added
the
do not merge
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
davidgamez
changed the title
davidgamez
removed
the
do not merge
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 265d9a2 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 940ff27 📊 Notices ComparisonNew Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1601 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
cka-y
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Memory consumption depends on the JVM state when the memory is collected; there is a considerable difference between reference(master) and latest(PR) executions.
From our AI friend ;-) :
This pull request includes significant changes to the
output-comparatormodule, focusing on refactoring the memory usage comparison logic and improving the performance metrics collection. The most important changes include the removal of theBoundedPriorityQueueclass, the introduction of new comparators, and the refactoring of theValidationPerformanceCollectorclass to streamline memory usage reporting.Memory Usage Comparison Refactor:
BoundedPriorityQueueclass, which was previously used for maintaining bounded priority queues of dataset memory usage. (BoundedPriorityQueue.java)UsedMemoryDecreasedComparatorclass to compareDatasetMemoryUsageobjects based on the minimum difference in used memory. (UsedMemoryDecreasedComparator.java)UsedMemoryIncreasedComparatorclass to compareDatasetMemoryUsageobjects based on the maximum difference in used memory, reversing the comparison for sorting purposes. (UsedMemoryIncreasedComparator.java)Validation Performance Collection Refactor:
ValidationPerformanceCollectorclass to remove the use ofBoundedPriorityQueueand instead use lists for memory usage tracking. (ValidationPerformanceCollector.java)PerformanceMetricsclass and added methods to compute average, median, standard deviation, min, and max values. (ValidationPerformanceCollector.java) [1] [2]generatePerformanceMetricsLogto format and append metrics to the log string. (ValidationPerformanceCollector.java) [1] [2]These changes aim to improve the maintainability and readability of the memory usage comparison logic and enhance the performance metrics reporting in the
output-comparatormodule.