-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version number on the Validate page #230
Conversation
Also @fredericsimard (now that you're looking at our translation processes) and @emmambd: |
@isabelle-dr For translation maintenance, I'd recommend that it's simpler doing it before the PR's merged. |
My 2 cents: |
Thank you @derhuerst ! Let's keep the version number then. I've opened a PR to add this step to our validator release documentation so we don't forget. I was assuming that we were deploying as part of making a release, which would mean that latest release version and deployed version were the same at all times. @derhuerst, the report also displays the version (see below). And it's the latest currently 🙂 |
@derhuerst Currently the executable downloads, the jars and the web validator are all at 4.2.0 But you do make a good point. We need to be more transparent on the version that is running, so I think the web version should display the validator version (not just in the report) and docs/schedule/validate.md should not have to be updated manually (maybe it can display the current version from a https://github.com/MobilityData/gtfs-validator/wiki/Current-Version?) |
We might have a misunderstanding here: I want the currently running version to be displayed in both the validation form and the report. It should be taken from the deployed code (executable, jar or Docker image) itself. This is especially help when I want to archive historical reports. Displaying whatever is the latest available version is interesting, but of secondary importance to me, given that I can always look that information up manually. (Or set up some auto-update, e.g. using Dependabot & the Docker image.) |
Merging this PR since the version number has been updated. From the conversation here, I opened two follow-up issues:
Also, I've added this PR to the translation backlog. Thank you @derhuerst 🙏 |
My comment presupposed that the version used by the web validator is the latest one as found in the Current-Version file. |
Removed the version number from this page so that we don't have to manually change it every time we have a release.
The link to the latest release notes stays.
cc @jcpitre