-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Recently Merged Proposals Section in GTFS Schedule Changes #233
Conversation
Added 7 PRs recently merged (from Jul to Nov 2023)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @Sergiodero!
It might be worth sharing that the initial idea for this page was to give a quick overview of the latest features available in GTFS (i. e. the "big" things, compared to the Revision History)
So among the new records you've added here, I think we could remove:
- fare media type 1
- clarify implied timezone
- specify shape_dist_traveled
- forbid sub-folders
Also, I am wondering when to remove older records also 🤔 so this list continues to be "Recent".
Maybe we could try and have approx the past 2 years here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 keep major changes only, to differentiate Revision History page.
2 year sounds good to me, inclined to calendar year instead of fiscal year so we don't have to check too frequently.
Removes the following points from the from previous commit: - Fare media type 1 - Clarify implied timezones - Specify shape_dist_traveled - Forbid subfolders It also removes old changes (before 2022)
Hi! I've posted a new commit to address your comments, this cuts the 4 suggested records from the previous commit and also deletes all spec changes made before 2022. Could you take another look? @tzujenchanmbd @isabelle-dr thanks! |
@Sergiodero suggest adding networks files one. Looks like it got adopted after opening this PR. LGTM for other parts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after adding networks.txt, thanks!
To whoever will be merging this PR: don't forget to update the translation backlog! Thanks :) |
Added networks, merging. Thanks! |
Added to the translation backlog |
This PR updates the GTFS Schedule Changes page (schedule/changes/index.md) to include 7 PRs recently merged (from Jul to Nov 20230 into the spec into the Recently Merged Proposals section.
@isabelle-dr @tzujenchanmbd Could you take a look? Thanks!