-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: support SurvSHAP computation with {treeshap} #85
Conversation
…xactly one row due to indexing of y_true to first element and if not using y_true the function produces strange results
including support for global survshap values and unit-tests
…l times from explain-object addresses ModelOriented#75
…rder for kernelshap and treeshap
- removed data.table parts - updated error handling - added unit tests for treeshap (both, local and global shap) addresses ModelOriented#75
…hod in surv_shap which caused error of github action unittests when using 'exact_kernel'
Unit-test showed error regarding missing |
update dev branch
update upstream commits
collect and update upstream enhancements
merge latest upstream changes
Hi @mikolajsp and @krzyzinskim , |
Hi @kapsner,
As you mentioned |
Hi @krzyzinskim , thanks a lot. The PR looks good and thanks for mentioning me as a contributor of the |
@kapsner, Unfortunately, I made one silly mistake while trying to generalize the functions for explanations also for CHFs. I've already managed to find the mistake and fixed it. However, using the version available on CRAN results in the explanations for the survival curves not being calculated properly. Sorry for that. With CRAN's policy in mind, I don't want to do a new submission straight away. Maybe I will use this week or two to try to add support for another survival model (maybe In the meantime, I'll merge this PR to a separate branch to work in parallel on the integration with survex. |
@krzyzinskim , I understand the topic with the CRAN policy well - in the end, they want to avoid more than 6 or 7 CRAN submissions per year. I had that once with one of my packages, however, providing a reasonable explanation in the cran-comments allowed us to also update the package even more often (although this should be an exception). Waiting for another survival model makes indeed sense 👍 For the Best, |
This PR adds the feature to compute (global and local) SurvSHAP values with the {treeshap} algorithm, which drastically decreases computation time for
ranger
survival models as compared to using the currently implemented {kernelshap} algorithm.Furthermore, this PR enables to compute SurvSHAP with models that were trained with data objects of type
matrix
.Unit-tests have been added as well.
Addresses #75 .
The only thing I've just identified as a potential challenge is that {treeshap} is not on CRAN yet - are there plans to bring {treeshap} to CRAN in the near future?