-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor compression and XOR last model value #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skejserjensen
force-pushed
the
dev/residuals-xor-model-last
branch
from
May 22, 2023 13:57
b79c26a
to
306f8d5
Compare
CGodiksen
requested changes
May 23, 2023
CGodiksen
requested changes
May 23, 2023
CGodiksen
approved these changes
May 23, 2023
chrthomsen
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a challenge to read through :-) I did not find not any problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch started as an endeavor to improve the compression of residual values by XORing the first residual value with the model's last value instead of storing the first residual value in full. However, doing so proved to be very difficult due to the less than ideal structure the compression crate had ended up with (a combination of functions and builders with unclear separation of responsibility) as functionality was added over time. Thus, I had to give up halfway and refactor the compression crate. The crate now consists of the modules list below and the compression process is performed by three, hopefully, intuative builders (
ModelBuilder
->CompressedSegmentBuilder
->CompressedSegmentBatchBuilder
) whilecompression.rs
only operates as the driver that decides how to represent each part of the time series being compressed.ErrorBound
) intended for users of the crate.So while this PR make significant changes to the compression crate it is mostly refactoring. I have tried to make the PR simpler to review by rewriting the commit history so the refactoring is done first. Thus, a diff containing only the commits made after the refactoring can be seen here.