Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Coil utils module and a KmpFileFetcher #84

Merged
merged 1 commit into from
May 24, 2024

Conversation

iruizmar
Copy link
Contributor

Coil is a well-known network image loading library use by many people. In Coil, you can extend the image loading pipeline by adding, among others, custom fetchers that will express how to download an image given any model.

This PR adds a custom Coil Fetcher to be able to pass a KmpFile to Coil and it will display the local image gracefully.

@MohamedRejeb MohamedRejeb self-requested a review May 24, 2024 18:25
Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR, it's a really good feature to have.

@MohamedRejeb MohamedRejeb merged commit 69ea560 into MohamedRejeb:main May 24, 2024
1 check passed
@iruizmar
Copy link
Contributor Author

Should we document this somewhere? Otherwise, it'll be hard to find.

@MohamedRejeb
Copy link
Owner

MohamedRejeb commented Jul 3, 2024

Yes this should be documented here and used in the sample as well:
https://github.com/MohamedRejeb/Calf/blob/main/docs/filepicker.md

@iruizmar iruizmar deleted the coil_extensions branch July 15, 2024 13:18
@iruizmar iruizmar mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants