Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 #856

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Drop Python 3.8 #856

merged 1 commit into from
Nov 12, 2024

Conversation

mattwthompson
Copy link
Contributor

@mattwthompson mattwthompson commented Nov 12, 2024 •
edited
Loading

Description

This PR drops Python 3.8, which is past its EOL, from testing.

Status

  • Code base linted
  • Ready to go

@mattwthompson mattwthompson marked this pull request as ready for review November 12, 2024 14:41
@mattwthompson mattwthompson mentioned this pull request Nov 12, 2024
Merged
2 tasks
@bennybp
Copy link
Contributor

bennybp commented Nov 12, 2024

Thanks! That should be all that's needed.

I think it would still technically work with 3.8 but we just can't waste time testing it

@bennybp bennybp merged commit 655fa69 into MolSSI:main Nov 12, 2024
15 checks passed
@mattwthompson mattwthompson deleted the no-py38 branch November 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @bennybp