-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataops 906 multiqc updates #44
base: master
Are you sure you want to change the base?
Dataops 906 multiqc updates #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, I left some comments for you.
yaml.dump(qc_out, fout) | ||
with open(os.path.join(analysis_dir, "extra_stats.yaml"), "w") as fout: | ||
with open(os.path.join(outdir, "extra_stats.yaml"), "w") as fout: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something happened with the indentation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just something weird with the indentation on one line.
MultiQC updates:
removed multiqc_config_wgs_qc.yaml
updated multiqc_config_wgs.yaml
updated multiqc_pipeline_info.py
updated sample_list_for_multiqc.py
updated multiqc_sarek_project.sh
Before the project ID was parsed from the input path which is not ideal when running
multiqc from a non-canonical path e.g. FU projects.
multiqc_sarek_project $PWD
If these files would be moved to the multiqc_custom_content folder, as the other custom files, the QC check would be included in the user report as well.
new script multiqc_extra_stats_qc.py