Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run tests on each PR merge and push #655

Open
wants to merge 3 commits into
base: 0.0.6-beta
Choose a base branch
from

Conversation

YashKumarVerma
Copy link

No description provided.

@YashKumarVerma YashKumarVerma changed the title feat: run tests on each PR merge feat: run tests on each PR merge and push Mar 2, 2024
@DavidAJohnston
Copy link
Contributor

Thanks. However this might not be the correct repo. Pinging @betterbrand

@betterbrand
Copy link
Collaborator

@YashKumarVerma have you run these on the NODE repo?

@DavidAJohnston
Copy link
Contributor

Are these tests still current and should be merged or should I close this PR?
@betterbrand @YashKumarVerma

@srt0422
Copy link

srt0422 commented Aug 18, 2024

the test command does not run any tests. Tests should be developed before accepting the job. Actions are free up to a certain number of hours, but running this command on every branch push will exhaust a lot of those hours.

I suggest closing, and a simple test run can be added when there are tests to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants