Do not show login save/select if autofill is disabled (#3848)

MozillaReality · Aug 20, 2020 · f2e4a1c · f2e4a1c
1 parent 5b4597a
commit f2e4a1c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/browser/PromptDelegate.java b/app/src/common/shared/org/mozilla/vrbrowser/browser/PromptDelegate.java
@@ -296,7 +296,7 @@ public GeckoResult<PromptResponse> onLoginSave(@NonNull GeckoSession geckoSessio
         final GeckoResult<PromptResponse> result = new GeckoResult<>();
 
         // We always get at least one item, at the moment only one item is support.
-        if (autocompleteRequest.options.length > 0) {
+        if (autocompleteRequest.options.length > 0 && SettingsStore.getInstance(mContext).isAutoFillEnabled()) {
             Autocomplete.LoginSaveOption saveOption = autocompleteRequest.options[0];
             boolean originHasException = mSavedLoginBlockedSites.stream().anyMatch(site -> site.url.equals(saveOption.value.origin));
             if (originHasException || !SettingsStore.getInstance(mContext).isLoginAutocompleteEnabled()) {
@@ -335,7 +335,7 @@ public void confirm(@NonNull Login login) {
     public GeckoResult<PromptResponse> onLoginSelect(@NonNull GeckoSession geckoSession, final @NonNull AutocompleteRequest<Autocomplete.LoginSelectOption> autocompleteRequest) {
         final GeckoResult<PromptResponse> result = new GeckoResult<>();
 
-        if (autocompleteRequest.options.length > 1) {
+        if (autocompleteRequest.options.length > 1 && SettingsStore.getInstance(mContext).isAutoFillEnabled()) {
             List<Login> logins = Arrays.stream(autocompleteRequest.options).map(item -> GeckoLoginDelegateWrapper.toLogin(item.value)).collect(Collectors.toList());
             mSelectLoginPrompt = new SelectLoginPromptWidget(mContext, new SelectLoginPromptWidget.Delegate() {
                 @Override