Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mind dryad haunt #34

Closed
wants to merge 1 commit into from
Closed

Mind dryad haunt #34

wants to merge 1 commit into from

Conversation

keyz182
Copy link
Contributor

@keyz182 keyz182 commented Jul 20, 2024

#27

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move this into a loadfolder to only add it if athena is present, that way there's no dependency needed. Or alternatively add this to the haunts mod proper https://github.com/MrSamuelStreamer/Haunts

Copy link
Collaborator

@feldoh feldoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loadfolder this or move to https://github.com/MrSamuelStreamer/Haunts

@keyz182
Copy link
Contributor Author

keyz182 commented Jul 21, 2024

Would Loadfolder work? I think to be thorough, it'd need to depend on Athena and the Anima mod. I was about to say I'd need to see if Haunts will work on 1.5, but I see you've done that now, so I'll see about chucking it in there now.

@keyz182
Copy link
Contributor Author

keyz182 commented Jul 21, 2024

Closing in favour of MrSamuelStreamer/Haunts#2

@keyz182 keyz182 closed this Jul 21, 2024
@feldoh
Copy link
Collaborator

feldoh commented Jul 21, 2024

Would Loadfolder work? I think to be thorough, it'd need to depend on Athena and the Anima mod. I was about to say I'd need to see if Haunts will work on 1.5, but I see you've done that now, so I'll see about chucking it in there now.

FTR yes it would but you use one loadfolder and one either mayrequire or patchoperationfindmod. Conditional works too but you'd have to nest it. Could also be done by adding a mayrequire on athena for the comp and using a loadfolder for the anima mod which is probably the right way around. Trying to keep deps to minimal is good form if not strictly needed given sam knows all deps will be there

@keyz182 keyz182 deleted the haunts branch July 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants