Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext mon detector restructure #1325

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fine1-sam
Copy link
Contributor

Work in progress

There are overlapping geometries in the ext mon detector modules when the stackRotation flag is set to "true."

@FNALbuild
Copy link
Collaborator

Hi @fine1-sam,
You have proposed changes to files in these packages:

  • Mu2eG4
  • ExtinctionMonitorFNAL
  • GeometryService

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

The following users requested to be notified about changes to these packages:
@resnegfk

⌛ The following tests have been triggered for fa6a31b: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@gaponenko
Copy link
Contributor

To clarify: there are no overlaps with the default settings, and I will want to merge this work after a review.
Sam has completed his internship today, so if there are any change requests, I will take care of them.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for fa6a31b.

Test Result Details
test with Command did not list any other PRs to include
merge Merged fa6a31b at 01eb5be
build (prof) Log file. Build time: 04 min 12 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file. Return Code 36.
g4surfaceCheck Log file. Return Code 0.
FIXME, TODO 🔶 TODO (0) FIXME (1) in 8 files
clang-tidy 🔶 0 errors 180 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at fa6a31b after being merged into the base branch at 01eb5be.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke kutschke self-assigned this Aug 19, 2024
@kutschke kutschke marked this pull request as draft August 19, 2024 19:14
@kutschke
Copy link
Collaborator

I marked this as a draft since it's failing the CI tests.

@gaponenko What are the plans to move forward?

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to e389271. Tests are now out of date.

@brownd1978 brownd1978 assigned brownd1978 and unassigned kutschke Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants