Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragments to hits/digi with new calo decoders #1372

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

giro94
Copy link

@giro94 giro94 commented Nov 19, 2024

Drafting the pull request for updating CaloHitsFromFragments and CaloRecoFromFragments to accomodate the new CaloDecoder and be able to interpret all types of calo hits

@FNALbuild
Copy link
Collaborator

Hi @giro94,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 1682d93: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The build is failing at 1682d93.

scons: *** [build/al9-prof-e28-p063/Offline/tmp/DAQ/src/CaloRecoFromFragments_module.os] Error 1
Test Result Details
test with Command did not list any other PRs to include
merge Merged 1682d93 at 8421253
build (prof) Log file.
ceSimReco 〰️ Log file.
g4test_03MT 〰️ Log file.
transportOnly 〰️ Log file.
POT 〰️ Log file.
g4study 〰️ Log file.
cosmicSimReco 〰️ Log file.
cosmicOffSpill 〰️ Log file.
ceSteps 〰️ Log file.
ceDigi 〰️ Log file.
muDauSteps 〰️ Log file.
ceMix 〰️ Log file.
rootOverlaps 〰️ Log file.
g4surfaceCheck 〰️ Log file.
FIXME, TODO 🔶 TODO (1) FIXME (1) in 1 files
clang-tidy 🔶 7 errors 32 warnings
whitespace check 🔶 found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 1682d93 after being merged into the base branch at 8421253.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to a65235a. Tests are now out of date.

@gianipez
Copy link
Contributor

This PR needs to use Mu2e/artdaq_core_mu2e#40

@giro94
Copy link
Author

giro94 commented Nov 20, 2024

I have tested this module (CaloRecoFromFragments_module.cc) with real calo debug data (raw.mu2e.pulseInjection_cal.trig_gr3_streamer.000001_000000.art) and it works:

TrigReport ---------- Module summary ------------
TrigReport    Visited        Run     Passed     Failed      Error Name
TrigReport       9999       9999       9999          0          0 caloVerifier
TrigReport       9999       9999       9999          0          0 makeCaloReco
TrigReport       9999       9999       9999          0          0 outfile

Art has completed and will exit with status 0.

As said by @gianipez , this depends on Mu2e/artdaq_core_mu2e#40 and Mu2e/otsdaq_mu2e_calorimeter#15

@gianipez
Copy link
Contributor

@FNALbuild run build test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants