Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacy fabric support #9

Closed
wants to merge 7 commits into from
Closed

add legacy fabric support #9

wants to merge 7 commits into from

Conversation

thecatcore
Copy link

@thecatcore thecatcore commented May 4, 2022

superseeds #5

@jamierocks
Copy link

This passes off third-party intermediaries as being Fabric's - they should have unique uid.

@thecatcore
Copy link
Author

Doesn't FabricLoader depend on "net.fabricmc.intermediary" component to run? Changing the uid of LegacyFabric intermediary will require to change this too in this case 🤔.

@thecatcore
Copy link
Author

I tried to keep them separated at least in the upstream-meta repo, but not sure how to do it for the multimc-meta one

@jamierocks
Copy link

I would not expect MultiMC to pass this off as Fabric anyway, it's a third-party project.

Doesn't FabricLoader depend on "net.fabricmc.intermediary" component to run?

Yes it does.

Changing the uid of LegacyFabric intermediary will require to change this too in this case

No it shouldn't. I can think of two solutions to this off the top of my head:

  1. Have a Legacy Fabric 'Fabric Loader' component, which depends on it's own intermediaries.
  2. Remove the requirement from the Fabric Loader component.

@thecatcore
Copy link
Author

Updated accordingly

@thecatcore
Copy link
Author

How do I add "noapplet" trait to legacy fabric variant of Loader?

@thecatcore
Copy link
Author

Ready for review

@thecatcore thecatcore closed this Sep 21, 2022
@thecatcore thecatcore deleted the legacy-fabric branch September 21, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants