-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add legacy fabric support #9
Conversation
This passes off third-party intermediaries as being Fabric's - they should have unique uid. |
Doesn't FabricLoader depend on "net.fabricmc.intermediary" component to run? Changing the uid of LegacyFabric intermediary will require to change this too in this case 🤔. |
I tried to keep them separated at least in the upstream-meta repo, but not sure how to do it for the multimc-meta one |
I would not expect MultiMC to pass this off as Fabric anyway, it's a third-party project.
Yes it does.
No it shouldn't. I can think of two solutions to this off the top of my head:
|
Updated accordingly |
How do I add "noapplet" trait to legacy fabric variant of Loader? |
Ready for review |
superseeds #5